Skip to content

[Bookings] Booking details part 7 #16234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2025
Merged

[Bookings] Booking details part 7 #16234

merged 5 commits into from
Oct 13, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 10, 2025 •
edited
Loading

Part of: WOOMOB-1236

Description

  • Implements UTC timezone dates formatting for booking details screen following the approach in bookings list.
  • Implements the customer phone actions sheet / popover
    • Presents popover from customer phone row in iPad
    • Presents bottom action sheet for customer phone on iPhone
    • Copy and call actions
    • "Phone number copied" confirmation toast for copy action
    • "Could not place a call to this number." error toast if the call is impossible (for example on simulators)

Testing steps

  • Test on both iPhone and iPad
  • Use a CIAB site with existing bookings
  • Find a booking with a customer that has a phone number specified (or create one)
  • Open booking details
  • Scroll down to customer phone row
  • Tap on the row (make sure it's tappable in whole area)
  • Make sure a popover or action sheet is presented containing phone number as a title and copy + call as actions
  • Select the "Copy" action. Make sure the copy confirmation toast is presented upon copying.
  • Select the "Call" action. Make sure the failure toast is presented on iOS Simulator.
  • Consider testing on a device to make sure that the phone call is happening.

Screenshots

iPhone iPad
Снимок экрана 2025-10-10 в 16 05 41 Снимок экрана 2025-10-10 в 16 03 36
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.5 milestone Oct 10, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 10, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 10, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16234-9a8dfa5
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit9a8dfa5
Installation URL3kmlm6delci0o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas
Copy link
Contributor

adborbas commented Oct 13, 2025

The code looks good and works as described 👍. I have three things to note.

  1. sendToPasteboard appends a new line at the end of the strings. This results in an orphan \n when pasting the phone number to Messages. See the attachment below.

Simulator Screen Recording - iPhone 17 Pro - 2025-10-13 at 10 18 35

  1. Nit: On iPad, the confirmation dialog is pinned to the center of the row rather than where you tapped. This results in the dialog seemingly popping out of nowhere
image
  1. I know this is how it looks in the design, but there is no option to send an email to the email address; just copying is supported. I'm wondering if this is something we should be supporting 🤔

adborbas
adborbas reviewed Oct 13, 2025
View reviewed changes
WooCommerce/Classes/ViewModels/Booking Details/AppointmentDetailsContent.swift
booking.startDate.formatted(date: .omitted, time: .shortened),
booking.endDate.formatted(date: .omitted, time: .shortened)
booking.startDate.toString(dateStyle: .none, timeStyle: .short, timeZone: BookingListTab.utcTimeZone),
booking.endDate.toString(dateStyle: .none, timeStyle: .short, timeZone: BookingListTab.utcTimeZone)
Copy link
Contributor

@adborbas adborbas Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate on why utcTimeZone is used for formatting?

Copy link
Contributor Author

@RafaelKayumov RafaelKayumov Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the Huong's suggestion here: #16214 (review)

There is discussion thread about timezone usage for bookings: p1759398245019489-slack-C09FHQNQERG where it's confirmed that we should use the UTC timezone

@RafaelKayumov
Copy link
Contributor Author

RafaelKayumov commented Oct 13, 2025

@adborbas Thx for the review.

sendToPasteboard appends a new line at the end of the strings. This results in an orphan \n when pasting the phone number to Messages. See the attachment below.

Trailing line removed in 9a8dfa5

Nit: On iPad, the confirmation dialog is pinned to the center of the row rather than where you tapped. This results in the dialog seemingly popping out of nowhere

This is how it's done elsewhere (for example in "Order details" screen). For now I would stick to existing approach unless there is a clear input from design. I'm also looking into making the detail section narrow in the same way we have it for Order Details. I guess this will make the popup appearance more understandable.

Simulator Screenshot - iPad (A16) - 2025-10-13 at 13 18 36

I know this is how it looks in the design, but there is no option to send an email to the email address; just copying is supported. I'm wondering if this is something we should be supporting 🤔

Same here - I'd just follow the design for MVP purposes. We can re-iterate and follow the same approach that we have in Order Details to present action sheet for email instead of just copying.

@RafaelKayumov RafaelKayumov merged commit 4fc86e3 into trunk Oct 13, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1236-booking-details-part-7 branch October 13, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adborbas adborbas adborbas approved these changes

@itsmeichigo itsmeichigo Awaiting requested review from itsmeichigo

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelKayumov @wpmobilebot @adborbas